Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user config dir to store tls artifacts #2129

Merged
merged 26 commits into from
Jun 9, 2021
Merged

Use user config dir to store tls artifacts #2129

merged 26 commits into from
Jun 9, 2021

Conversation

refs
Copy link
Member

@refs refs commented Jun 7, 2021

Closes #114

@update-docs
Copy link

update-docs bot commented Jun 7, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@refs refs changed the title Use user system config to store tls artifacts Use user config dir to store tls artifacts Jun 7, 2021
@refs refs requested review from IljaN and wkloucek June 7, 2021 17:37
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2021

Please retry analysis of this Pull-Request directly on SonarCloud.

proxy/pkg/flagset/flagset.go Outdated Show resolved Hide resolved
@refs refs requested a review from wkloucek June 8, 2021 08:45
@refs refs requested a review from LukasHirt as a code owner June 8, 2021 08:49
@refs
Copy link
Member Author

refs commented Jun 8, 2021

hm, @C0rby: Test_ensureExistsDir" to match the regular expression ^(_|[a-zA-Z0-9]+)$ should not really apply for test files. In this case I'm testing a private method, so the test file MUST be in the same package, if I create a something_test package then I cannot unit test unexported methods anymore. Is there a way to disable that rule? It's pretty useless for this scenario, and not a code smell.

@C0rby
Copy link
Contributor

C0rby commented Jun 8, 2021

@refs, I think the rule is just complaining about the underscore in the test function name, you shouldn't have to create a test package IMHO.

@refs
Copy link
Member Author

refs commented Jun 8, 2021

@refs, I think the rule is just complaining about the underscore in the test function name, you shouldn't have to create a test package IMHO.

Yeah, I had assumed Test_funcName was the convention hmmm... I guess I'll rename them to TestFuncName

@refs
Copy link
Member Author

refs commented Jun 8, 2021

@refs, I think the rule is just complaining about the underscore in the test function name, you shouldn't have to create a test package IMHO.

You're right, I had assumed Test_funcName was the convention hmmm... I guess I'll rename them to TestFuncName

@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.5% 70.5% Coverage
1.9% 1.9% Duplication

@refs refs merged commit 72aa597 into master Jun 9, 2021
@refs refs deleted the tls-config-location branch June 9, 2021 12:09
ownclouders pushed a commit that referenced this pull request Jun 9, 2021
Merge: 8251e62 33f8cd0
Author: Alex Unger <6905948+refs@users.noreply.github.com>
Date:   Wed Jun 9 14:09:23 2021 +0200

    Merge pull request #2129 from owncloud/tls-config-location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure default write location
3 participants